[JBIDE-15967] app wiz: trigger envvar button visibility on domain change #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -493,6 +494,7 @@ public IDomain getDomain() throws OpenShiftException { | |||
|
|
|||
| public void setDomain(IDomain domain) throws OpenShiftException { | |||
| firePropertyChange(PROPERTY_DOMAIN, wizardModel.getDomain(), wizardModel.setDomain(domain)); | |||
| setEnvironmentVariablesSupported(isEnvironmentVariablesSupported()); | |||
There was a problem hiding this comment.
wont this mean a remote call is done everytime this method is called which happens during typing/updating ?
There was a problem hiding this comment.
nope, the domains are loaded upon page showing up: https://github.com/adietish/jbosstools-openshift/blob/72df870a10c7b5c8d8bcb97d4cd2536821ac8bd2/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/application/ApplicationConfigurationWizardPage.java#L1069
The domains that we get then are cached. Thus no remote will happen any more. All checks are done on cached values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.