JBIDE-16407 Breakinbg connection between openshift and legacy framework... #355
Conversation
…rk for servers. updating dependency version removing legacy classes small cleanup of patch
|
Please test this patch before accepting it. I know my testing abilities on openshift are not where they need to be so it'd be good to get another tester to verify. |
|
is this unrelated to the refactoring of server that is not yet in master ? |
|
This is related, and the goal is to decouple logic that has no reason at all to coupled. In this way, openshift no longer depends on these classes at all, and puts its publishing logic 100% in the hands of openshift plugin instead of delegating around through a framework. So I would say its related, but not dependent. It's also something I suggested be cleaned up months ago, as well as the unused classes for a 'binary' behavior which does not exist. |
To be clear, openshift would need to commit this change if my work ever makes it into master. But, even if my work never makes it into master, openshift would benefit from a cleaner workflow by applying this patch. |
|
Okey - then i'm just confused sicne the reasons on JBIDE-16407 seems to be counter to the changes planned for openshift. Maybe take this to the jira where other reasons a listed ? |
|
this was merged in #358 together with further changes (ex. disabling start/stop/restart) |
... for servers.
updating dependency version
removing legacy classes
small cleanup of patch