[JBIDE-13158] removed connection lookup by usename and host #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed ConnectionsModel#getConnectionByUsernameAndHost since this is not required any more. This was used when embedding cartridges on an existing application. This code was created when JBT was using the legacy client. With the new client applications can be create with the domain, no need to lookup the connection any more
|
Patch works great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed ConnectionsModel#getConnectionByUsernameAndHost since this is
not required any more. This was used when embedding cartridges on an
existing application. This code was created when JBT was using the
legacy client. With the new client applications can be create with the
domain, no need to lookup the connection any more