Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBIDE-19555] Refactor to use openshift-restclient-java #593

Conversation

jcantrill
Copy link
Contributor

@adietish Please merge ASAP along with the client auth changes. This change utilizes the new repo

<nature>org.eclipse.pde.PluginNature</nature>
<nature>org.eclipse.jdt.core.javanature</nature>
</natures>
</projectDescription>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you removing the Eclipse project file? Without it I can hardly see Eclipse properly working? I bet this was by mistake.

@jcantrill jcantrill force-pushed the jbide_19555_use_openshift_restclient branch from 0414de3 to f114eb1 Compare April 7, 2015 20:13
@@ -5,6 +5,7 @@ bin/

.project
.plugins/.project

plugins/org.jboss.tools.openshift.client/.project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would you want to ignore those Eclipse configuration files (all of them, the ones below, too)?

@@ -20,8 +20,14 @@
<arguments>
</arguments>
</buildCommand>
<buildCommand>
<name>org.eclipse.m2e.core.maven2Builder</name>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@adietish
Copy link
Member

adietish commented Apr 8, 2015

@jcantrill

dependencies are specified in the manifest file and are pulled in when you import.
Given thats the case, what is the point of placing these file under source control

manifest is runtime, java build path/pom are build-time. So m2e bridges manifest to build-time by setting the java build path from what I sees in manifest.
So the point is that you force people to use m2e. You can only use Eclipse to develop plugin projects, Whats the point of forcing people to install m2e? It only causes initial lifecycle errors upon import which you have to solve upon import, Furthermore m2e frequently gets out-of-sync with the settings in .project and needs to be to told update (Maven->Update project). M2e slows the build cycle and has no additional benefit. Compiling and launching is all done with Eclipse, maven just sits there and idles. I really dont see any benefit in having m2e involved here.
Furthermore we are in a manifest-first approach here, not pom first: look at our poms, they're basically empty, maven gets it's settings from what's in manifest, not the other way round. Why would you want to inverse the approach and state that what maven detects (from Manifest) should be set to Eclipse settings?

@adietish
Copy link
Member

adietish commented Apr 8, 2015

rebased, removed empty plugin.xml, added .classpath back in, removed m2e natures:
#595

@adietish adietish closed this Apr 8, 2015
@jcantrill jcantrill deleted the jbide_19555_use_openshift_restclient branch October 16, 2015 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants