New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JBIDE-19555] Refactor to use openshift-restclient-java #593
[JBIDE-19555] Refactor to use openshift-restclient-java #593
Conversation
<nature>org.eclipse.pde.PluginNature</nature> | ||
<nature>org.eclipse.jdt.core.javanature</nature> | ||
</natures> | ||
</projectDescription> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you removing the Eclipse project file? Without it I can hardly see Eclipse properly working? I bet this was by mistake.
0414de3
to
f114eb1
Compare
@@ -5,6 +5,7 @@ bin/ | |||
|
|||
.project | |||
.plugins/.project | |||
|
|||
plugins/org.jboss.tools.openshift.client/.project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would you want to ignore those Eclipse configuration files (all of them, the ones below, too)?
@@ -20,8 +20,14 @@ | |||
<arguments> | |||
</arguments> | |||
</buildCommand> | |||
<buildCommand> | |||
<name>org.eclipse.m2e.core.maven2Builder</name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
manifest is runtime, java build path/pom are build-time. So m2e bridges manifest to build-time by setting the java build path from what I sees in manifest. |
rebased, removed empty plugin.xml, added .classpath back in, removed m2e natures: |
@adietish Please merge ASAP along with the client auth changes. This change utilizes the new repo