[JBIDE-20043] Do not collapse tree when deleting a resource #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.viewer = (StructuredViewer) viewer; | ||
| this.viewer = (TreeViewer) viewer; | ||
| if(input != null) { | ||
| input.removeListener(connectionListener); |
There was a problem hiding this comment.
what if connectionListener is null?
jcantrill
force-pushed
the
20043_delete_resource_collapsing_tree
branch
from
ae283d3
to
e5f11e8
Compare
jcantrill
force-pushed
the
20043_delete_resource_collapsing_tree
branch
from
e5f11e8
to
bb577b9
Compare
|
I still have the NPE: java.lang.NullPointerException
at org.jboss.tools.openshift.internal.ui.explorer.OpenShiftExplorerContentProvider.refreshGrouping(OpenShiftExplorerContentProvider.java:83)
at org.jboss.tools.openshift.internal.ui.explorer.OpenShiftExplorerContentProvider.handleConnectionChanged(OpenShiftExplorerContentProvider.java:58)
at org.jboss.tools.openshift.internal.common.ui.explorer.BaseExplorerContentProvider$ConnectionsRegistryListener.connectionChanged(BaseExplorerContentProvider.java:217)
at org.jboss.tools.openshift.common.core.connection.ConnectionsRegistry.fireChange(ConnectionsRegistry.java:158)
at org.jboss.tools.openshift.common.core.connection.ConnectionsRegistry.fireConnectionChanged(ConnectionsRegistry.java:116)
at org.jboss.tools.openshift.internal.ui.job.DeleteResourceJob.doRun(DeleteResourceJob.java:48)
at org.jboss.tools.openshift.internal.common.core.job.AbstractDelegatingMonitorJob.run(AbstractDelegatingMonitorJob.java:36)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
I suggest that you maybe rebase to latest master, maybe current master behaves differently? |
|
@adietish fixed with this openshift/openshift-restclient-java#36 |
|
ok, after pulling and building openshift-restclient-java no NPE any more. |
|
rebased, merged and pushed to upstream/master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adietish This also includes a refactor of the view refresh logic by moving it to the model.