[JBIDE-19146] load legacy connections #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
| List<String> connections = new ArrayList<String>(); | ||
| connections.addAll(Arrays.asList(ExpressCorePreferences.INSTANCE.loadConnections())); | ||
| connections.addAll(Arrays.asList(ExpressCorePreferences.INSTANCE.loadLegacyConnections())); | ||
| return connections.toArray(new String[connections.size()]); |
There was a problem hiding this comment.
that's a convoluted way to concatenate arrays. Rather use commons-lang ArrayUtils.addAll(first, second);
|
+1 to apply once arrays concatenation is fixed |
|
why is there such thing as legacy connections ? didn't we keep the old format even for the new ones ? |
|
This was where in some old version connections were stored. The current impl was not reading thos, something I now added. |
|
so its fixing and additional issue ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.