[JBIDE-20095] impl'ed validation for parameters #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adietish
force-pushed
the
JBIDE-20095
branch
2 times, most recently
from
70a1e8a
to
5518d40
Compare
adietish
changed the title
|
@fbricon plz review |
| @@ -110,39 +125,116 @@ public void doubleClick(DoubleClickEvent event) { | |||
| .align(SWT.FILL, SWT.FILL).applyTo(resetButton); | |||
| resetButton.setText("Reset"); | |||
| resetButton.addSelectionListener(onReset()); | |||
|
|
|||
| Label requiredExplanationLabel = new Label(templateParametersGroup, SWT.None); | |||
| requiredExplanationLabel.setText("* = value required, edit or double click to change them."); | |||
There was a problem hiding this comment.
click the 'Edit...' button or double-click on a value to edit it.
|
LGTM, if you can change the label as commented above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y trackEvent(). So we will send all events right away instead of counting them for 24 hours.