[JBIDE-20463] reset token value when new connection is selected #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fred Bricon <fbricon@gmail.com>
| @@ -223,8 +222,7 @@ private void disposeBindings() { | |||
| @Override | |||
| protected void onSelectedConnectionChanged(IObservableValue selectedConnection) { | |||
| IConnection conn = (IConnection) selectedConnection.getValue(); | |||
| if(!(conn instanceof Connection)) return; | |||
| detailViewModel.setSelectedConnection((Connection)conn); | |||
| detailViewModel.setSelectedConnection(conn); | |||
There was a problem hiding this comment.
Is there a reason to remove the instance check?
There was a problem hiding this comment.
yes, setSelectedConnection takes an IConnection argument, and the instance check prevents NewConnectionMarker instances to be set, which leads to the UI not being reset.
|
@fbricon assuming it resolves the issue, it LGTM |
|
Applied in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fred Bricon fbricon@gmail.com