[JBIDE-20407] Validate resource names before app creation #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @SuppressWarnings("serial") | ||
| private IStatus createErrorStatusForExistingResources(Collection<IResource> resources) { | ||
| final StringBuffer b = new StringBuffer(); |
There was a problem hiding this comment.
it's ok to use StringBuilders nowadays ;-)
jcantrill
force-pushed
the
20407_validate_resource_name_before_app_create
branch
from
2c457b6
to
dc079c7
Compare
jcantrill
force-pushed
the
20407_validate_resource_name_before_app_create
branch
from
dc079c7
to
4061bcd
Compare
|
@fbricon StringBuilder for your pleasure. @maxandersen updated comment based on your feedback. Please review |
|
+1 to apply. Nice job Jeff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fbricon Please review