[JBIDE-20599] Allow the handler to set the connection instead of recent #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| cmboProject.setSorter(new ViewerSorter() { | ||
| @Override | ||
| public int compare(Viewer viewer, Object e1, Object e2) { |
There was a problem hiding this comment.
shouldn't default always be on top?
There was a problem hiding this comment.
It should, but maybe we should consider removing it all together. I'm not sure how the current ording works in the explorer window. I assume it returns in order of what was returned by the call. I dont know whay it wouldnt do the same here.
|
Applied in master and 4.3.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fbricon review?