Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JBIDE-20974] Fix project combo regression in deploy image #792

Closed
wants to merge 1 commit into from
Closed

[JBIDE-20974] Fix project combo regression in deploy image #792

wants to merge 1 commit into from

Conversation

jcantrill
Copy link
Contributor

  • Fixes regression in populating the project combo
  • An issue using ConnectionAware with BeanProperties where setConnction wasnt found
  • The project combo height when there are initially no entries

@jcantrill
Copy link
Contributor Author

@adietish @fbricon please review

adietish
adietish reviewed Oct 19, 2015
View reviewed changes
...on.ui/src/org/jboss/tools/openshift/internal/common/ui/connection/ConnectionWizardModel.java
@@ -37,9 +37,8 @@ public IConnection getConnection() {
}

@Override
public IConnection setConnection(IConnection connection) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this connected to the erroneous behaviour?

@adietish
Copy link
Member

+1 LGTM

@jcantrill
Copy link
Contributor Author

Closing. Pushed to 4.3.x and cherry-picked into master

@jcantrill jcantrill closed this Oct 19, 2015
@jcantrill jcantrill deleted the 20974_project_combo_deploy_image_regression branch October 19, 2015 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcantrill @adietish