[JBIDE-21359] Add build tab to explorer deployment view #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @Override | ||
| public void refresh() { | ||
| page.refresh(); |
There was a problem hiding this comment.
shouldn't you check if page is disposed before refreshing?
There was a problem hiding this comment.
There is no 'isDispose' method
There was a problem hiding this comment.
no there isnt, but you could do
DisposeUtils.isDisposed(page.getControl())
|
As a general note, try to avoid using parallel streams unless it may help to solve some performance issues. http://stackoverflow.com/questions/20375176/should-i-always-use-a-parallel-stream-when-possible |
jcantrill
force-pushed
the
21359_builds_tab
branch
from
ae9daa0
to
48a8d43
Compare
|
@fbricon updated per your comments |
jcantrill
changed the title
jcantrill
force-pushed
the
21359_builds_tab
branch
from
48a8d43
to
6e03728
Compare
jcantrill
force-pushed
the
21359_builds_tab
branch
from
6e03728
to
caf5870
Compare
|
part of feature branch: feature_19178_deployment_view |
|
Closing as merged into feature branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.