JBIDE-21460 NPE at Show In Web Browser for OpenShift server if connection is not connected #912
Conversation
| if(service == null) { | ||
| throw new GetWelcomePageURLException("Service is missing."); | ||
| } | ||
|
|
||
| IProject project = service.getProject(); |
There was a problem hiding this comment.
Not specific to your pull, but there is no need to get a project to get the routes. You can accomplish this same call using the connection and retrieving the required project information by service#getNamespace(). This additionally saves you a REST call to load the project resource, and you could remove the throw from the null project all together.
There was a problem hiding this comment.
Thank you for the suggestion. Done.
scabanovich
force-pushed
the
jbide-21460
branch
3 times, most recently
from
f022ba7
to
531a422
Compare
| } | ||
| } catch (OpenShiftException e) { | ||
| ExpressCoreActivator.pluginLog().logError(expectedConnectionProblem, e); | ||
| throw new GetApplicationException(expectedConnectionProblem); |
There was a problem hiding this comment.
imho we should not swallow the root OpenShiftException but pass it to the new exception
There was a problem hiding this comment.
Ok, done. Now, this catch does not log the error, it is to be logged or shown in a message dialog or rethrown where this method is called.
scabanovich
force-pushed
the
jbide-21460
branch
4 times, most recently
from
8890f9d
to
bda0388
Compare
scabanovich
force-pushed
the
jbide-21460
branch
from
bda0388
to
ffe1ca2
Compare
scabanovich
force-pushed
the
jbide-21460
branch
from
ffe1ca2
to
e41aff1
Compare
…tion is not connected OpenShift core plugin has no ui to show dialog, so problem is reported with special exceptions to be displayed by client ui plugin.
|
ok, cool: no NPE, a dialog that tells me that the connection is not established yet. |
|
merging to jbosstools-4.3.x and master |
OpenShift core plugin has no ui to show dialog, so problem is reported with special exceptions
to be displayed by client ui plugin.