JBIDE-20751 Wizard closing dialog shown upon canceling a creation of a project in process of creating a new OpenShift 3 application #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scabanovich
force-pushed
the
jbide-20751
branch
from
da5233f
to
1b57ead
Compare
…a project in process of creating a new OpenShift 3 application It was the original idea to close New Application wizard entirely if user cancelled creation of required project. There was bug in it, it is fixed. Logic for when wizard should be closed or not is enhanced to consider these 3 cases: 1. File-> New -> OpenShift Application or JBoss Central -> OpenShift Application started; user selects connection and after Next, Select Template page is opened and dialog New Project is opened automatically (when project list is empty). In this case, New Application wizard should not be closed on project creation cancel because user has the option to push Back and select another connection. 2. Context menu on connection New -> Application is started; dialog New Project is opened automatically (when project list is empty). In this case New Application wizard should be closed on project creation cancel. 3. New Project dialog is started through Manage Projects link. In this case, no matter how New Application wizard is started, it should not be closed if project creation is cancelled.
scabanovich
force-pushed
the
jbide-20751
branch
from
1b57ead
to
2cce2f7
Compare
| @@ -785,6 +786,13 @@ public IStatus runInUIThread(IProgressMonitor monitor) { | |||
| } | |||
| }).build(); | |||
| WizardUtils.runInWizard(jobs, getContainer()); | |||
| if(closeAfter[0]) { | |||
There was a problem hiding this comment.
wouldn't that be called before the jobs have a chance to finish?
There was a problem hiding this comment.
No, other jobs go in ui thread and should be completed before this method continues.
There was a problem hiding this comment.
can you add that as a comment in the code, someone else might find it suspicious too
|
Applied in master / 4.3.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was the original idea to close New Application wizard entirely
if user cancelled creation of required project. There was bug in it, it is fixed.
Logic for when wizard should be closed or not is enhanced to consider these 3 cases:
user selects connection and after Next, Select Template page is opened
and dialog New Project is opened automatically (when project list is empty).
In this case, New Application wizard should not be closed on project creation cancel
because user has the option to push Back and select another connection.
dialog New Project is opened automatically (when project list is empty).
In this case New Application wizard should be closed on project creation cancel.
In this case, no matter how New Application wizard is started,
it should not be closed if project creation is cancelled.