JBIDE-20719 Updating a token for OpenShift 3 connection via Edit Connection does not update resources #951
Conversation
| return false; | ||
| } | ||
| return true; | ||
| } | ||
| } |
There was a problem hiding this comment.
Having a special #equals for credentials seems legit since we consider 2 connections as identical if they only differ in authentication means (ex. password or token). On the other hand the username is used to persist them and thus is required to identify and #equal 2 connections. I thus dont think that #equals may be true while Objects.equals(getUsername(), other.getUsername()) returns false.
There was a problem hiding this comment.
Ok, I moved comparing userName to eduals().
scabanovich
force-pushed
the
jbide-20719
branch
2 times, most recently
from
216382d
to
0b235f1
Compare
…ection does not update resources
scabanovich
force-pushed
the
jbide-20719
branch
from
0b235f1
to
eac1d95
Compare
| //It is safe to cast now. | ||
| Connection other = (Connection)connection; | ||
| //User name is already compared | ||
| if(!Objects.equals(password, other.password)) { |
There was a problem hiding this comment.
I assume that a purely token based connection will always have null in the password?
I admit that this part is rather fuzzy in our current Connection implementation, we have the authentication strategies but then we still have the password and username in connection. We should clean this stuff up at some point I think
|
looks good, I couldnt test it, but if you tested it (in the UI, too - i saw the unit tests :) ) then I'd +1 |
|
I tested it works, with both username change and token update |
|
Applied in master / 4.3.x. Thanks @scabanovich ! |
No description provided.