JBIDE-21697 Server Adapter: user choose choose default route when creating the server #964
Conversation
| return welcomePageUrl = url; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
this block would be an excellent candidate for a method #getRoute(String url). The invoking code would be more more clear (we're trying to pick the right route by the settings stored in the adapter/project and fall back to the user choosing it):
IRoute route = getRoute(OpenShiftServerUtils.getRouteURL(server), routes);
if (route != null) {
welcomePageUrl = route.getURL();
} else {
route = getRoute(routes);
if (route != null) {
welcomePageUrl = route.getURL();
}
}
return welcomePageUrl;
There was a problem hiding this comment.
btw. we're loading routes here from the server, is this code invoked in a background job by the WTP framework? I see a Display.syncExec hidden in the RouteChooser which is kinda unexpected, but I guess that's bcs it gets invoked at various places within jobs.
There was a problem hiding this comment.
Ok. done.
ShowInWelcomePageActionProvider executes the action in a non-ui job, and after it gets url, displays it using asyncExec.
scabanovich
force-pushed
the
jbide-21697
branch
2 times, most recently
from
8b9d8bb
to
17fb6c9
Compare
scabanovich
force-pushed
the
jbide-21697
branch
from
17fb6c9
to
4d6cb67
Compare
|
nice, thanks! |
No description provided.