JBIDE-21718 Possible IllegalArgumentException in ServiceDetailViews.TemplateDetailView.onVisible #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| String labels = org.jboss.tools.openshift.common.core.utils.StringUtils.toString(service.getLabels()); | ||
| if(labels != null) { | ||
| labelsText.setText(labels); | ||
| } |
There was a problem hiding this comment.
what if value is null? the text seems not to get reseted and would then still display the old value? shouldnt we reset it in this case?
Btw. org.apache.commons.lang.StringUtils.defaultString(string) returns an empty string if the input is null.
…emplateDetailView.onVisible
scabanovich
force-pushed
the
jbide-21718
branch
from
c515c5c
to
fb1b15a
Compare
|
applied in master/4.3.x. Thanks Slava! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.