JBIDE-21490 Enforce non empty git source parameter in templates #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So the problem is the validation only happens in the master dialog, not the actual editor dialog, see http://screencast.com/t/Q3j1UMRiry. The error message only shows up after editing the value |
scabanovich
force-pushed
the
jbide-21490
branch
3 times, most recently
from
063f745
to
682bd7b
Compare
scabanovich
force-pushed
the
jbide-21490
branch
from
682bd7b
to
8cb82b4
Compare
|
Applied in master/4.3.x. Thanks Slava! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.