JBIDE-21760 NPE is thrown on addition of a first pod-service mapping in Deploy docker image wizard

[scabanovich]

IServicePort.getTargetPort() returns null.
The fix reverts podPort.equals(newPort) to newPort.equals(podPort) because newPort is checked above for null.
@jcantrill, could you please check if it is allowed for IServicePort.getTargetPort() to return null.

[jcantrill]

@scabanovich it does not return null. I have a PR #984 which will change this, but I think this should be added regardless.

[scabanovich]

Ok, then IServicePort.getTargetPort() by design never returns null. But exception in the issue was caused because it happened at some case. If it was another bug and it is fixed, it is good. Still, maybe UI should be protected from this NPE as suggested, because future changes may again cause it. (If something may go wrong it will go wrong - Murphy's law )

[fbricon]

Applied in master/4.3.x Thanks @scabanovich !