JBIDE-21764 Duplicates of environment variables should be forbidden #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,13 +31,16 @@ | |||
| + "including the character '_', allowed anywhere except first position."; | |||
|
|
|||
| private final IStatus FAILED; | |||
| private static final IStatus NAME_IS_USED_ERROR = ValidationStatus.error("An enviaronment variable with this name exists"); | |||
There was a problem hiding this comment.
s/enviaronment/environment
s/exists/already exists
|
works for me, +1 |
scabanovich
force-pushed
the
jbide-21764
branch
from
94f4d19
to
cfed300
Compare
|
btw. the standard in OpenShift is to decorate required empty fields with a "*", not with an error marker. and return |
|
rebased and merged into master, cherry-picked to jbosstools-4.3.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.