JBIDE-15126 server forcefully shuts down on module event instead of server event #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -236,7 +236,8 @@ protected void initialize(IProgressMonitor monitor) { | |||
| serverStateVal = getServer().getServerState(); | |||
| getServer().addServerListener(new IServerListener() { | |||
| public void serverChanged(ServerEvent event) { | |||
| if( event.getState() != serverStateVal ) { | |||
| boolean isServerChangeEvent = ((event.getKind() & ServerEvent.SERVER_CHANGE) != 0); | |||
| if( isServerChangeEvent && event.getState() != serverStateVal ) { | |||
| Trace.trace(Trace.STRING_FINER, "Framework has changed server state from starting to stopped. Ensuring server has stopped."); //$NON-NLS-1$ | |||
There was a problem hiding this comment.
i know its unrelated to fix but shouldnt this trace be inside the next if ?
There was a problem hiding this comment.
...and should this be a info log ? how often would this happen ?
|
+1 for fix since it is necessary now we have module state changes causing crashes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.