JBIDE-14979 new bundle for wildfly jars to master #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private boolean isConnectionCloseException(Exception e) { | ||
| return (e instanceof IOException | ||
| && e.getMessage() != null | ||
| && (e.getMessage().indexOf("Channel closed") > -1) // pre-AS 7.1 client lib |
There was a problem hiding this comment.
^ shouldn't happen with wildfly right?
There was a problem hiding this comment.
i believe it can still occur so i will leave the lines in.
|
So except for the plugin name (I'd rather prefer wildfly8 than as8), the rest looks ok. Code duplication is not ideal but justified. LGPL bits already existed in the as71 package, so nothing new here. I'm approving the PR but don't be surprised if you're asked to rename the package/plugin once @maxandersen gets back. |
| <phase>generate-resources</phase> | ||
| </execution> | ||
| </executions> | ||
| <configuration> |
There was a problem hiding this comment.
add <skip>false</skip> into configuration to fix errors for new builds with -DskipTests flag.
JBIDE-14979 moving jars into a lib folder, prepare for removal of jars entirely via pom.xml prereq JBIDE-14979 final commit with rebuild to verify JBIDE-14979 not sure why the libs were added JBIDE-14979 cleanup to minimize the number of classes and changs required in such bundles JBIDE-14979 cleanup JBIDE-14979 more updates to ensure all use cases work JBIDE-14979 more updates to ensure all use cases work JBIDE-14979 more updates to ensure all use cases work updates as per fred updates as per fred and other cleanup JBIDE-14979_v2 - pom.xml fix as per dgolovin JBIDE-14979 rename plugin to wildfly8 instead of as8 Missed some string substitutions Further string substitutions JBIDE-14979
|
I pushed this to master with a rebase, so hashes don't match. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.