JBIDE-15901 maint - remote jmx not working for wf/eap6.x #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| String defaultUser = ServerConverter.getJBossServer(server).getUsername(); | ||
| String defaultPass = ServerConverter.getJBossServer(server).getPassword(); | ||
| IJBossServer jbs = ServerConverter.getJBossServer(server); | ||
| String storedOrDefaultUser = jbs.getUsername(); |
There was a problem hiding this comment.
couldn't jbs be null at this time for non-jboss server types or things like openshift ?
There was a problem hiding this comment.
Non-jboss server types or things like openshift currently have no adapter to JMX connections. If they wanted to add it, they would need to either implement it on their own, or, open an API request, request a new interface, or something like that. Either way, they should not be using an internal class named JBossServerConnection raw and expect it to work.
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A credentialing issue has re-surfaced and is a regression due to a bad patch previously applied.