JBIDE-16505 #195
Closed
JBIDE-16505 #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| protected void completeRemoval(IModule m) { | ||
| // AS7 requires the .deployed markers to be removed. Other servers require no action |
There was a problem hiding this comment.
Do you mean all AS7 derived servers like WF or just AS7.x ?
There was a problem hiding this comment.
as7-derived. I'll start to use that where applicable in the future instead of just as7
JBIDE-16505 test case Changes as requested from PR comments Changes as requested from PR comments Changes as requested from PR comments
| @@ -0,0 +1,103 @@ | |||
| package org.jboss.tools.as.test.core.subsystems.impl; | |||
|
OK to apply once the missing copyright header is added |
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
95% of the patch is the test case. Ensuring .deployed marker is removed after a remove publish