JBIDE-16865 maint #213
Merged
JBIDE-16865 maint #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 (and yeah thats some crappy wtp api..shouldn't we open up RFE at eclipse to fix that) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Servertools (for some unknown reason) only instantiates each wizard fragment (basically, wizard page) once. This makes it difficult to keep state here, or know exactly when to reset state. After a user has already made an AS7.1 server, for example, the next time they attempt to make one, the existing fragment is re-used. All of the widgets are currently disposed. But, the page is expected to know whether or not the page is complete BEFORE the user enters the page. and thus, before the composite (and new widgets) have been created.
Pain in the butt, for sure. Easy workaround though.