JBIDE-18262 - protect against invalid version ranges when matching runtimes #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd check that if the version contains more than 3 dots, (X.Y.Z.whatever), then extra dots are replaced with _ |
|
I would love to see some unit tests for that parsing thing :-) |
robstryker
force-pushed
the
JBIDE-18262
branch
2 times, most recently
from
0790c52
to
01a624b
Compare
…ntimes JBIDE-18262 - revised JBIDE-18262 - added test JBIDE-18262 - added test
robstryker
force-pushed
the
JBIDE-18262
branch
from
01a624b
to
a974f0c
Compare
|
+1 to apply |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.