JBIDE-18347 - changing local server profile to mgmt should change poller... #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ler; also unify names between AS versions
| --> | ||
| <serverPoller | ||
| class="org.jboss.ide.eclipse.as.core.server.internal.v7.JBoss7ManagerServicePoller" | ||
| id="org.jboss.ide.eclipse.as.core.server.Wildfly8ManagerServicePoller" | ||
| name="Wildfly Manager Service" |
There was a problem hiding this comment.
why does the name change ? is it just to not have any visual difference in UI ?
the name is not used as key, right?
There was a problem hiding this comment.
Name is not used as key. I felt current name values were inappropriate since EAP 6.3 would have "AS7 Manager Service". This really seemed innappropriate and really a more generic term should be used.
|
+1, patch looks safe and works. Just a bit confusing that the editor closes and reopens when the user clicks on the "ok" button to confirm the profile behavior change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...; also unify names between AS versions