JBIDE-18451 - NPE in jvmmonitor code during initialization if no valid j... #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robstryker
force-pushed
the
JBIDE-18451
branch
from
5894338
to
b6800a1
Compare
| @@ -412,6 +412,9 @@ protected InputStream invokeHeapHisto(Object virtualMachine, boolean isLive) | |||
| * @return The error message or <tt>null</tt> if not found | |||
| */ | |||
| public String validateJdkRootDirectory(String jdkRootDirectory) { | |||
| if( jdkRootDirectory == null || jdkRootDirectory.isEmpty()) { | |||
There was a problem hiding this comment.
jdkRootDirectory.trim().isEmpty() is even better
|
+1 to apply, once trim added |
…d jdk location is found JBIDE-18451 - NPE in jvmmonitor code during initialization if no valid jdk location is found JBIDE-18451 - added trim
robstryker
force-pushed
the
JBIDE-18451
branch
from
b6800a1
to
88b4fd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...dk location is found