JBIDE-18501 - autodetected jvms missing hashcode and equals methods leav... #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
|
|
||
| private JvmKey getJvmKey(IActiveJvm jvm) { |
There was a problem hiding this comment.
why not cache this jvmkey instance so we do not trash create them on every call to hascode/key ?
…eaving jmx nav full of stale references JBIDE-18501 - autodetected jvms missing hashcode and equals methods leaving jmx nav full of stale references
robstryker
force-pushed
the
JBIDE-18501
branch
from
f03ee2d
to
1fcaf6b
Compare
|
I tested this and for me I have the following: EXEC: open JMX Navigator and unfold "Local Processes"
Seems correcting the issue! |
|
I can confirm it works too, built against 4.2.x. good fix. +1for apply |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ing jmx nav full of stale references