[JBIDE-19218] Fix startup extension point error #327
Conversation
|
|
||
| public void earlyStartup() { | ||
| JBossServerCorePlugin.getDefault(); | ||
| } |
There was a problem hiding this comment.
Hey Denis: Why are we removing this line here? Pretty sure we need as.core to start up when as.ui starts, since as.core adds listeners and various other things that need to be added.
There was a problem hiding this comment.
I am missing one file here, with empty IStartup implementation, I'll update PR.
There was a problem hiding this comment.
It is bad practice to have a plug-in activator and early workspace start up implemented in one class, so I split it and added class attribute which pointing to new ISturtup implementation.
earlyStartup method is empty, because it will trigger bundle activation on class load and everything else are going to work the same way as before, but no anti patterns and no error markers in manifest.
dgolovin
force-pushed
the
JBIDE-19218
branch
from
b53a44f
to
f45a9a7
Compare
|
Denis: what you're missing here is that we need AS Core to start when AS UI starts. If AS UI starts without Core, then we have problems. Listeners don't get added and models don't get built. With your patch, as.ui will start up early, but will not start as.core. |
dgolovin
force-pushed
the
JBIDE-19218
branch
from
f45a9a7
to
6e138f6
Compare
|
Damn laziness :) updated PR. |
Fix extracts ISturtup implementation into separate class and set its name as startup@class attribute value in extensin point
dgolovin
force-pushed
the
JBIDE-19218
branch
from
6e138f6
to
812eb49
Compare
|
Rob, I tested it again and it works as expected now. server.core gets activated. could you release it into master? |
|
Rebased and pushed to master. Thanks for the patch, Denis! |
Fix extracts ISturtup implementation into separate
class and set its name as startup@class attribute
value in extensin point