JBIDE-21460 NPE at Show In Web Browser for OpenShift server if connection is not connected #392
Conversation
| public void run() { | ||
| MessageDialog.openWarning( | ||
| PlatformUI.getWorkbench().getActiveWorkbenchWindow().getShell(), | ||
| "No Welcome URL to Show", e.getMessage()); |
There was a problem hiding this comment.
I believe the action is now called Show-in -> Web Browser, not welcome page. The welcome page terms are legacy and hidden. Can we change this message to be more generic? No URL found for current selection" or something like that?
scabanovich
force-pushed
the
jbide-21460
branch
2 times, most recently
from
9f25b80
to
5ac3528
Compare
|
This would break API and not be suitable for maintenance. The JIRA is targeted to maintenance. You'd need to prove that there are no other callers of this API in any other JBT code :( |
|
@robstryker , can it help if we make GetWelcomePageURLException extending RuntimeException instead of regular Exception. Then we do not need to declare it in 'throws' for the method so that API will not be changed. Javadoc may describe in full what and when is thrown. I know, this is kind of breaking through the back door, but it will work. Would you accept it? |
|
I might, if you also do a grep on most jbt repos to check who else is using the API ;) Just so we know who else is affected BEFORE we commit it. |
|
The complete search over github (do can we trust them?) gives results: jbosstools-server Plus copies of these files at nickboldt/jbosstools-svn-mirror and nickboldt/temp-jbosstools-server. And, yes CreateServerCheckDefaultsTest now is affected and does not compile. |
Unfortunately it's defacto-API as others are extending it all over :( If you fix the test and also provide a matching patch to openshift, and make sure openshift now depends on the newest version of astools to ensure no mixed environments, it should be acceptable. |
|
by 'newest' i mean the maintenance in which we expect the new exception to be present in.... not master. we don't want openshift maintenance to depend on astools master |
|
Can it be solved by setting in manifest of openshift plugins org.jboss.ide.eclipse.as.core;bundle-version="3.1.1" ? |
…tion is not connected ServerExtendedProperties.getWelcomePageUrl() is mode to throw GetWelcomePageURLException to show message in a warning dialog. Implementation may decide to log problem with stacktrace if message in dialog is not sufficient.
scabanovich
force-pushed
the
jbide-21460
branch
from
5ac3528
to
2b72b54
Compare
|
@robstryker , I have updated PR, please look if I did it right. |
|
@robstryker can you please validate this so that we can merge the PR in openshift that depends on this? |
|
pushed to master and maintenance |
ServerExtendedProperties.getWelcomePageUrl() is mode to throw GetWelcomePageURLException
to show message in a warning dialog. Implementation may decide to log problem with stacktrace if
message in dialog is not sufficient.