JBIDE-21949 - Allow user to turn on/off showing console when output changes #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robstryker could you review this PR please ? |
|
Do we want to change the interface too? It's new so you can change it. Otherwise these changes won't be really available to most implementations. |
|
Actually I think you should add it to the interface. There will be some clients who do wish ti to be active on write. In fact, I'd suggest it should be active-on-write by default since that's the previous behavior. |
|
@robstryker ok, let me revert the default behaviour in the API, then |
…hanges Changing the code to show the message console when it is created only, then offering two methods to write lines in the shell and activate the view or not (default is 'true'). Also, upgrading the project's execution environment to Java 1.7 to take advantage of the 'try-with-resources' statement to make sure that the outputstream is closed upon writting. Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
|
@robstryker I updated the patch after your review (thanks about it !). Please let me know if this is better now ;-) |
|
looks great, +1, i'll merge. |
|
thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the code to show the message console when it is created only,
then offering two methods to write lines in the shell and activate the
view or not (default).
Also, upgrading the project's execution environment to Java 1.7 to take
advantage of the 'try-with-resources' statement to make sure that the
outputstream is closed upon writting.
Signed-off-by: Xavier Coulon xcoulon@redhat.com