JBIDE-22601 - fix regression causing error starting rse.mgmt profile … #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if( alwaysThrow && !s.isOK()) { | ||
| throw new CoreException(s); | ||
| } | ||
| return s; | ||
| } | ||
|
|
||
| public IStatus validateServerHome(IServer server, IServerDetailsController details, | ||
| IDeploymentOptionsController options, IFilesystemController fs) throws CoreException { |
There was a problem hiding this comment.
You are breaking API of a public class/method here. Do we really have to do it? Why not deprecate the old method and add a new one. You can ignore options here.
There was a problem hiding this comment.
the class is only a month old and nobody else uses it yet. In fact the introduction of this class is what broke the code in the first place.
|
LGTM. |
…server Small error, no return Wrong separator character
|
pushed to master and respin-b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…server