Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor itests to use RedDeer2 #536

Merged
merged 1 commit into from
Sep 11, 2017
Merged

Conversation

rawagner
Copy link
Member

@rawagner rawagner commented Sep 7, 2017

Signed-off-by: Rastislav Wagner rawagner@redhat.com

@robstryker
Copy link
Member

Hey @rawagner - I can't merge this because it won't build. Are changes needed to TP first?

Signed-off-by: Rastislav Wagner <rawagner@redhat.com>
@rawagner
Copy link
Member Author

rawagner commented Sep 8, 2017

@robstryker you are correct. We need to wait for TP 4.71 and also jbosstools/jbosstools-base#593 needs to be merged (also depends on TP 4.71).

@psrna
Copy link
Member

psrna commented Sep 11, 2017

testPR

1 similar comment
@nickboldt
Copy link
Member

testPR

@nickboldt nickboldt merged commit a92e4d3 into jbosstools:master Sep 11, 2017
@rhdevelopers-ci
Copy link

SonarQube analysis reported 20 issues

  • CRITICAL 2 critical
  • MAJOR 5 major
  • MINOR 11 minor
  • INFO 2 info

Top 10 issues

  1. CRITICAL ServerRequirementConfig.java#L67: Rename this constant name to match the regular expression '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'. rule
  2. CRITICAL ServerRequirementConfig.java#L78: Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. rule
  3. MAJOR ServerRequirement.java#L61: Remove this call to "equals"; comparisons between unrelated types always return false. rule
  4. MAJOR ServerRequirement.java#L260: Add the "@OverRide" annotation above this method signature rule
  5. MAJOR JBossServer.java#L159: Rename this method; there is a "private" method in the parent class with the same name. rule
  6. MAJOR JBossServer.java#L163: Rename this method; there is a "private" method in the parent class with the same name. rule
  7. MAJOR DisableSecureStorageRequirement.java#L61: Remove this unused method parameter "checked". rule
  8. MINOR ServerMatcher.java#L25: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  9. MINOR ServerMatcher.java#L29: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  10. MINOR ServerMatcher.java#L33: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants