[JBIDE-26756] added support for EAP 7.3

[adietish]

No description provided.

[adietish]

in jenkins build #347 AllSubsystemResolutionTest is failing:

Test Result (10 failures / ±0)
org.jboss.tools.as.test.core.subsystems.AllSubsystemResolutionTest.testResolution[org.jboss.ide.eclipse.as.eap.73, local, launchTabProvider]
org.jboss.tools.as.test.core.subsystems.AllSubsystemResolutionTest.testResolution[org.jboss.ide.eclipse.as.eap.73, local, server.ports]
org.jboss.tools.as.test.core.subsystems.AllSubsystemResolutionTest.testResolution[org.jboss.ide.eclipse.as.eap.73, rse, launchTabProvider]
org.jboss.tools.as.test.core.subsystems.AllSubsystemResolutionTest.testResolution[org.jboss.ide.eclipse.as.eap.73, rse, server.ports]
org.jboss.tools.as.test.core.subsystems.AllSubsystemResolutionTest.testResolution[org.jboss.ide.eclipse.as.eap.73, null, launchTabProvider]
org.jboss.tools.as.test.core.subsystems.AllSubsystemResolutionTest.testResolution[org.jboss.ide.eclipse.as.eap.73, null, server.ports]
org.jboss.tools.as.test.core.subsystems.AllSubsystemResolutionTest.testResolution[org.jboss.ide.eclipse.as.eap.73, local.mgmt, launchTabProvider]
org.jboss.tools.as.test.core.subsystems.AllSubsystemResolutionTest.testResolution[org.jboss.ide.eclipse.as.eap.73, local.mgmt, server.ports]
org.jboss.tools.as.test.core.subsystems.AllSubsystemResolutionTest.testResolution[org.jboss.ide.eclipse.as.eap.73, rse.mgmt, launchTabProvider]
org.jboss.tools.as.test.core.subsystems.AllSubsystemResolutionTest.testResolution[org.jboss.ide.eclipse.as.eap.73, rse.mgmt, server.ports]

Furthermore local results dont match jenkins: I have tests failing even in master while jenkins is green for master.
And then baseline checks go crazy, they complain about changes in archives for a feature. Disabling the checks have no effect (-Dtycho.baseline=disable as pointed out in parent pom). Looks very similar to https://www.eclipse.org/lists/tycho-user/msg08141.html
@jeffmaury how do you usually handle this?

[adietish]

tests all fail with an NPE:

java.lang.NullPointerException
	at org.jboss.tools.as.test.core.subsystems.AllSubsystemResolutionTest.setUp(AllSubsystemResolutionTest.java:140)

Looks like a missing file org.jboss.tools.as.test.core/serverMock/eap7.3.0.mf.jboss-as-server.jar. No idea how to create it, simply copying the 7.2 version and renaming it. Looking how this goes.
@robstryker how to correctly create the above file (I simply copied the jar for 7.2 which looks different from it's predecessors)?

[adietish]

@psrna finally jenkins build #351 is a green build. Please review.

[jeffmaury]

@adietish for the mock jar the rule is the following: identify in the 7.3 distribution the corresponding jar (if I remember correctly this is jboss or wildlfy server module) and remove everything except metadata (META-INF). If you can't wait until @robstryker or @jeffmaury are back

[jeffmaury]

I need more time to validate the PR. Unless @robstryker approves it, please wait for my return

[jeffmaury]

This line should be updated as well

[adietish]

@jeffmaury I've been told that this is urgent and needs to be available by next week.
Looks like this is the one you're pointing at, correct?

Removed everything but META-INF, renamed it & added a README.txt that points this out.

[adietish]

@psrna can QE please test this?

[jeffmaury]

Why is it that urgent ? It was planned long ago on my schedule and planned to be started when I will be back. I still feel it's not complete but if it is that urgent go for it and I will deeply check it when I will be back

[odockal]

@adietish I have noted just a couple of issues, but I would rather to take a look into detail on Monday.

[odockal]

@adietish Here it goes:

1. Not yet functional: Download and install - also missing record in jboss-stacks/stacks.yaml file

2. Adding EAP 7.3 Beta server into EAP 7.3 Server adapter introduced warning about beta vs. 7.3 may cause critical errors.

3. No new facet module versions for EAP 7.3 runtime type? 37ab396#diff-bd70d3ab4ac4ee1a51cf5f94af0cf6c7R1246

[adietish]

@jeffmaury about the urgency: middleware informed us that they want the adapter to be ready when they release 7.3 this week.

[adietish]

@odockal thx for testing this.

1. Looks to me as if the stacks file contains md5 sums & exact file sizes (look here: https://github.com/jboss-developer/jboss-stacks/blob/1.0.0.Final/stacks.yaml#L3293). I thus dont see how we can have this file augmented before we have the final release.
   btw. where is this file?
2. I'd think that this warning only exists as long as there's no final release.
3. I dont know about the facets, is there a spec?

[odockal]

@adietish Please note that I am just summarizing things I think we need to fix or know about and do them once they are ready.

1. Looks to me as if the stacks file contains md5 sums & exact file sizes (look here: https://github.com/jboss-developer/jboss-stacks/blob/1.0.0.Final/stacks.yaml#L3293). I thus dont see how we can have this file augmented before we have the final release.
   btw. where is this file?

• You found the file, it is correct one, but we do not need to it now as it was not yet released. But do not forget about it.

2. I'd think that this warning only exists as long as there's no final release.

• agree, or maybe when server is using beta libs? Or when the server is Beta?

3. I dont know about the facets, is there a spec?

• No idea, but judging based on previous commits that brought new adapter. It also brought new facet module versions. I will to find some specs about modules, so far no luck.

[odockal]

New issues:
Adding server via runtime detection does not recognize EAP 7.3 but rather some older one (maybe default)
Steps:

1. Preferences -> Server -> Runtime Environment -> Search -> Path to EAP 7.3 server
2. Expected: Dialog with EAP 7.3 server adapter offering
   Actual: EAP 6 server adapter instead (and as a bonus, closing the dialog will spawn empty window that's just hanging)
   

[odockal]

@adietish Wait a minute.... I deleted second issue. Wrong bits.

[adietish]

@odockal sorry, confused, is the issue above valid?

[odockal]

@adietish the above one yes.

[adietish]

@odockal ok, thx for spotting this, I can reproduce it. Fixing it.

[adietish]

@odockal fixed the runtime detection issue. Please review.

[odockal]

@adietish Seems fine. I checked runtime-detection, now there is EAP 7.3 detected. although I did not tests everything as some thing like after start runtime detection can be verified from snapshot. So it will need to be double checked after merging as well. Tech preview is at place, thanks for that.

[adietish]

@odockal thx for testing and pointing out deficiencies. Helped a lot.

[adietish]

@odockal if I get the versions right I'd guess that eap 7.3 should match the capabilities of wildfly 17, is this correct (referring to the facets that you brought up)?

[odockal]

@adietish Yes, that sounds like good starting point. It should be based on wildfly 17.

[adietish]

@odockal just verified, both are identical:

• wildfly 17 (https://github.com/jbosstools/jbosstools-server/blob/master/as/plugins/org.jboss.ide.eclipse.as.core/plugin.xml#L2410):

          <moduleType types="jst.appclient" versions="5.0, 6.0,7.0,8.0"/>
          <moduleType types="wst.web" versions="1.0,1.2,1.3,1.4"/>
          <moduleType types="jst.web" versions="2.2, 2.3, 2.4, 2.5, 3.0,3.1,4.0"/>
          <moduleType types="jst.ejb" versions="1.0, 1.1, 2.0, 2.1, 3.0, 3.1,3.2"/>
          <moduleType types="jst.ear" versions="1.2, 1.3, 1.4, 5.0, 6.0,7.0,8.0"/>
          <moduleType types="jst.connector" versions="1.0, 1.5, 1.6,1.7"/>
	  <moduleType types="jst.utility" versions="1.0"/>
          <moduleType types="jboss.package" versions="1.0"/>
          <moduleType types="jboss.singlefile" versions="1.0"/>
          <moduleType types="jst.jboss.sar" versions="1.0"/>
          <moduleType types="jbt.bpel.module" versions="1.1, 2.0"/>
          <moduleType types="bpel.module" versions="1.1, 2.0"/>
          <moduleType types="jboss.osgi" versions="1.0"/>

• eap 7.3 (https://github.com/jbosstools/jbosstools-server/pull/637/files#diff-bd70d3ab4ac4ee1a51cf5f94af0cf6c7R850)

          <moduleType types="jst.appclient" versions="5.0, 6.0,7.0,8.0"/>
          <moduleType types="wst.web" versions="1.0,1.2,1.3,1.4"/>
          <moduleType types="jst.web" versions="2.2, 2.3, 2.4, 2.5, 3.0, 3.1, 4.0"/>
          <moduleType types="jst.ejb" versions="1.0, 1.1, 2.0, 2.1, 3.0, 3.1, 3.2"/>
          <moduleType types="jst.ear" versions="1.2, 1.3, 1.4, 5.0, 6.0,7.0,8.0"/>
          <moduleType types="jst.connector" versions="1.0, 1.5, 1.6,1.7"/>
	  <moduleType types="jst.utility" versions="1.0"/>
          <moduleType types="jboss.package" versions="1.0"/>
          <moduleType types="jboss.singlefile" versions="1.0"/>
          <moduleType types="jst.jboss.sar" versions="1.0"/>
          <moduleType types="jbt.bpel.module" versions="1.1, 2.0"/>
          <moduleType types="bpel.module" versions="1.1, 2.0"/>
          <moduleType types="jboss.osgi" versions="1.0"/>

[odockal]

@adietish I checked as well, all three EAP 7.2, WF 17 and EAP 7.3 Beta are the same.

[robstryker]

Thanks for getting this done guys. +1