JBIDE-14299 convert astools to use new runtimes extension point and use stacks #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…point and use stacks updated to reflect progress monitors JBIDE-14299_use_stacks more work to conform to stacks Depend on common.core until o.j.t.core is committed JBIDE-14299 final cleanup
|
I've merged the code in without any API changes. The API changs and deprecations will be reserved for cleanup jiras. |
|
How do you know if it works without even single test for this new plugin? |
|
I knew you'd ask that ;) Tests are coming, speciically to verify that the id's of the downloadruntimes haven't changed (because central depends on them). I suppose I should have made it part of this commit. I tested both locally (runtime workbench) and by building locally and verifying all pieces were built, and installing from the local update site. I believe that's sufficient, but, tests are coming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attached PR (at this moment) is not fully complete. It requires the changes to base (new core component) to be approved. Also, it currently directly links to a custom stacks file in my own jdf topic branch simply as a convenience to let me code the thing up.
But, it works. Nicely 👯