JBIDE-27976 Adding more tests for Show In context menu #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lgrossma <lgrossma@redhat.com>
odockal
requested changes
Oct 5, 2021
| new ContextMenu().getItem("Show In", "Web Browser").select(); | ||
| for (MenuItem item : items) { | ||
| if (item.getText().contains("Web Management Console")) { | ||
| isInMenu = true; |
There was a problem hiding this comment.
Put only a return statement here in order to not iterate over every item in the list. you need only first fulfilled condition.
|
|
||
| return isInMenu; |
There was a problem hiding this comment.
simply return false here. no need to keep it in variable during iteration.
Signed-off-by: lgrossma <lgrossma@redhat.com>
odockal
approved these changes
Oct 13, 2021
|
@lgrossma One more thing, can you please paste an image of successful jenkins run? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lgrossma lgrossma@redhat.com
@odockal @jkopriva
Adding test cases for the rest of the options in server's "Show In" menu.