New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WildFly 26 server and include other UI tests fixes and patches #745

Merged

odockal merged 1 commit into jbosstools:master from odockal:wf-26-itests

Jan 10, 2022

Member

odockal commented Jan 6, 2022

Signed-off-by: Ondrej Dockal odockal@redhat.com

Pull Request Checklist

General

Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

Are method-/class-/variable-names meaningful?
Are methods concise, not too long?
Are catch blocks catching precise Exceptions only (no catch all)?

Testing

Are there unit-tests?
Are there integration tests (or at least a jira to tackle these)?
Is the non-happy path working, too?
Are other parts that use the same component still working fine?

Function

Does it work?

Member Author

odockal commented Jan 6, 2022

@jeffmaury Could you please add @olkornii to the repo commiter so he can perform reviews? thanks!


          Add WildFly 26 server and include other UI tests fixes and patches

9ae9868

Signed-off-by: Ondrej Dockal <odockal@redhat.com>

odockal force-pushed the wf-26-itests branch from 1b49b59 to 9ae9868 Compare

January 6, 2022 13:17

Member

olkornii commented Jan 10, 2022

LGTM
https://studio-jenkins-csb-codeready.apps.ocp4.prod.psi.redhat.com/job/Studio/job/Quality/job/Integration-tests/job/server-itests/

olkornii approved these changes

View reviewed changes

odockal merged commit b24ac94 into jbosstools:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment