Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreatingArchiveTest control focus bug fix #763

Merged
merged 1 commit into from Aug 4, 2022
Merged

CreatingArchiveTest control focus bug fix #763

merged 1 commit into from Aug 4, 2022

Conversation

xbabalov
Copy link

@xbabalov xbabalov commented Aug 4, 2022

Pull Request Checklist

General

  • Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

  • Are method-/class-/variable-names meaningful?
  • Are methods concise, not too long?
  • Are catch blocks catching precise Exceptions only (no catch all)?

Testing

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Is the non-happy path working, too?
  • Are other parts that use the same component still working fine?

Function

  • Does it work?

@xbabalov
CreatingArchiveTest bug fix, JBIDE-28578
c5eb491 
Signed-off-by: Tamara Babalova <tbabalov@redhat.com>
@odockal odockal self-requested a review August 4, 2022 09:40
@odockal odockal merged commit 57698b5 into jbosstools:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odockal odockal odockal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xbabalov @odockal