JBIDE-15969: Remove useless m2e extensions from TP

[mickaelistria]

No description provided.

[nickboldt]

Just make sure these are not needed to build JBDS, or else we'll need to ensure they're in the Central TP and that we reference the Central TP when building JBDS.

[mickaelistria]

I verified and those features are not part of jbds feature.

If they're necessary for discovery sites, we'll move them there.

Mickael Istria
Eclipse developer at JBoss, by Red Hat http://www.jboss.org/tools
My blog http://mickaelistria.wordpress.com - My Tweets
http://twitter.com/mickaelistria

[nickboldt]

Looks like the only m2e-* in Central TP is m2e-wro4j.

https://github.com/jbosstools/jbosstools-discovery/blob/master/jbtcentraltarget/multiple/jbtcentral-multiple.target#L26

However, there are others in here, which would need to move from the JBT TP to the Central TP to be resolved:

https://github.com/jbosstools/jbosstools-discovery/blob/master/jbosstools/org.jboss.tools.central.discovery/plugin.xml :

        <iu id="org.eclipse.m2e.wtp.jaxrs.feature"/>
        <iu id="org.eclipse.m2e.wtp.jsf.feature"/>
        <iu id="org.jboss.tools.maven.jbosspackaging.feature"/>
        <iu id="org.eclipse.m2e.feature"/>
        <iu id="org.eclipse.m2e.wtp.feature"/>
        <iu id="org.eclipse.m2e.wtp.jpa.feature"/>
        <iu id="org.jboss.tools.maven.apt.feature"/>
        <iu id="org.jboss.tools.m2e.wro4j.feature"/>

[mickaelistria]

m2e-wtp stays in the "core" target platfrom, and m2e.wro4j is already in. So it looks like in this list, only maven.apt has to be added to the Central target platform. I'll make another PR for that.

[mickaelistria]

See also related PR for jbosstools-discovery jbosstools/jbosstools-discovery#126

[nickboldt]

What about jaxrs, jsf, jpa?

[mickaelistria]

They're already in Core target-platform:
https://github.com/jbosstools/jbosstools-target-platforms/blob/4.40.x/jbosstools/multiple/jbosstools-multiple.target#L113

[nickboldt]

Right, but i thought you were looking to move these to Central. If they're needed by the base JBT/JBDS install, though, I suppose they need to stay where they are. Anyway, disco #126 is applied.

[mickaelistria]

I did not check whether these ius are necessary to install from JBT site or not. If they're not necessary to install JBT, we might be able to move them to Central as well.

[mickaelistria]

@nickboldt See https://issues.jboss.org/browse/JBIDE-15969?focusedCommentId=12931739&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12931739 , those features are required for JBT, so thay can't be moved.