Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JBIDE-28585: Update 4.25.0.AM1 TP for 2022-09 RC1 #396

Merged
merged 1 commit into from Sep 6, 2022
Merged

JBIDE-28585: Update 4.25.0.AM1 TP for 2022-09 RC1 #396

merged 1 commit into from Sep 6, 2022

Conversation

sbouchet
Copy link
Contributor

@sbouchet sbouchet commented Sep 5, 2022

Signed-off-by: Stephane Bouchet sbouchet@redhat.com

@sbouchet
JBIDE-28585: Update 4.25.0.AM1 TP for 2022-09 RC1
56fb267 
Signed-off-by: Stephane Bouchet <sbouchet@redhat.com>
jeffmaury
jeffmaury approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
As a side note JDT.LS should be removed because we fixed Quarkus but LSP4MP tests have a non optional dependency on JDT.LS

@sbouchet
Copy link
Contributor Author

sbouchet commented Sep 6, 2022

LGTM As a side note JDT.LS should be removed because we fixed Quarkus but LSP4MP tests have a non optional dependency on JDT.LS

let's remove it on Final . see https://issues.redhat.com/browse/JBIDE-28635

@sbouchet sbouchet merged commit 07c7a89 into jbosstools:main Sep 6, 2022
@sbouchet sbouchet deleted the JBIDE-28585 branch September 6, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffmaury jeffmaury jeffmaury approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbouchet @jeffmaury