JBIDE-15120 BrowserSim does not launch on Java 6 32-bit JVM Mac OS X #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -141,6 +142,8 @@ private void fillValues() { | |||
| String message; | |||
| if (Platform.OS_WIN32.equals(Platform.getOS())) { | |||
| message = "BrowserSim/CordovaSim require a 32-bit JRE/JDK 6 or JDK 7 to be installed."; | |||
| } else if (PlatformUtil.OS_MACOSX.equals(PlatformUtil.getOs()) && PlatformUtil.ARCH_X86.equals(PlatformUtil.getArch())) { | |||
| message = "BrowserSim/CordovaSim require Java 6 to be installed."; | |||
There was a problem hiding this comment.
this is misleading.
Java 6 is only needed when OSX and running Eclipse 32-bit ?
it would work with Java 7 if user was runing 64-bit eclipse right ?
Then message should be something like:
"To run BrowserSim with Java 7 you must run 64-bit Eclipse or use Java 6 that supports 32-bit"
|
This looks good - getinto both branches? |
|
Applied in master and jbosstools-4.1.x branches as 207fe19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hotfix