JBIDE-12860 - JAX-RS validation problems are not linked #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @see {@link IMarker} for severity levels and values. | ||
| */ | ||
| abstract void setProblemLevel(final int level); |
There was a problem hiding this comment.
removal of this method affects API compatibility
Added a custom JAXRS_PROBLEM_TYPE attribute in JAX-RS markers. Those JAX-RS Problem markers are now indexed with Lucene. Thus, it becomes possible to look for resource that have the same error as a given resource, even if this later one has been deleted. (eg: looking for duplicate application problem after an application has been removed). When a JAX-RS Element is removed, its associated JAX-RS Markers are removed from the index *during the validation phase* (the markers still exist and are still indexed until the validation is performed). Added some JUnit tests to verify the good behaviour againts the case where a project has 2 JAX-RS application then one is removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review #86 first, as both PR provide changes for the same JaxrsMetamodelValidator class..