JBIDE-15428 - No JAX-RS problems when importing a project that contains HTTPMethod annotation without @Target and @Retention #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| new ResourceDelta(WtpUtils.getWebDeploymentDescriptor(getProject()), ADDED, 0), progressMonitor); | ||
| public synchronized void processProject(final IProgressMonitor progressMonitor) throws CoreException { | ||
| // avoid concurrent access on | ||
| synchronized(this) { |
There was a problem hiding this comment.
having both synchronized on method and then synchronized(this) means the same thing afaik.
…ns HTTPMethod annotation without @target and @retention Skipping the Java ElementChangeEvents when the Java Project is not open yet. This avoids race conditions during import. Bonus: import seem to be twice as fast as before ;-) Other changes: - Move the call the JaxrsMetamodel#setBuildStatus() to finally{} blocks of JaxrsMetamodel#processXXX() methods - Adjusted some javadoc, log messages and catch() blocks (avoiding to catch Exception or Throwable) - Added a ReadWriteLock on all public methods of the JaxrsMetamodel to avoid concurrent access to the metamodel by different threads, for example if an async build is still running and the validation is started. This avoids the following type of error: {code} !ENTRY org.jboss.tools.common 4 0 2013-10-09 18:17:54.307 !MESSAGE !STACK 0 org.jboss.tools.common.validation.JBTValidationException at org.jboss.tools.common.validation.ValidatorManager.validateInJob(ValidatorManager.java:101) at org.eclipse.wst.validation.internal.operations.ValidatorJob.run(ValidatorJob.java:78) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53) Caused by: java.util.ConcurrentModificationException at java.util.HashMap$HashIterator.nextEntry(HashMap.java:793) at java.util.HashMap$ValueIterator.next(HashMap.java:822) at org.jboss.tools.ws.jaxrs.core.internal.metamodel.validation.JaxrsMetamodelValidator.validateAll(JaxrsMetamodelValidator.java:268) at org.jboss.tools.ws.jaxrs.core.internal.metamodel.validation.JaxrsMetamodelValidator.validate(JaxrsMetamodelValidator.java:153) at org.jboss.tools.common.validation.ValidatorManager.validate(ValidatorManager.java:117) at org.jboss.tools.common.validation.ValidatorManager.validateInJob(ValidatorManager.java:81) ... 2 more {code} - added some tests to increase code coverage
|
+1 (see jira) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added accepted change event on a project: RESOLVED_CLASSPATH. This event is triggered when m2e adds the dependencies as libraries to the
project. In that case, a metamodel build should be triggered as it may resolve some compilation problems.
Move the call the JaxrsMetamodel#setBuildStatus() to finally{} blocks of JaxrsMetamodel#processXXX() methods
Adjusted some javadoc, log messages and catch() blocks (avoiding to catch Exception or Throwable)
Also, added a few synchronized() blocks to avoid concurrent access to the metamodel by different threads, for example if an async build
is still running and the validation is started. This avoids the following type of error:
{code}
!ENTRY org.jboss.tools.common 4 0 2013-10-09 18:17:54.307
!MESSAGE
!STACK 0
org.jboss.tools.common.validation.JBTValidationException
at org.jboss.tools.common.validation.ValidatorManager.validateInJob(ValidatorManager.java:101)
at org.eclipse.wst.validation.internal.operations.ValidatorJob.run(ValidatorJob.java:78)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)
Caused by: java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:793)
at java.util.HashMap$ValueIterator.next(HashMap.java:822)
at org.jboss.tools.ws.jaxrs.core.internal.metamodel.validation.JaxrsMetamodelValidator.validateAll(JaxrsMetamodelValidator.java:268)
at org.jboss.tools.ws.jaxrs.core.internal.metamodel.validation.JaxrsMetamodelValidator.validate(JaxrsMetamodelValidator.java:153)
at org.jboss.tools.common.validation.ValidatorManager.validate(ValidatorManager.java:117)
at org.jboss.tools.common.validation.ValidatorManager.validateInJob(ValidatorManager.java:81)
... 2 more
{code}