Deploy image to OpenShift 3 #496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - Service | ||
| - Route 'Optional' | ||
|
|
||
| *Note:* The following steps require: |
There was a problem hiding this comment.
[NOTE]
====================================================
The following steps require:
- Connection to a Docker daemon already exist
- Connection to an OpenShift 3 cluster already exist
- Openshift 3 project exist
====================================================
|
Thanks, @jcantrill. Looks good! When this request is merged, I'll replicate the information for the enterprise docs. |
jcantrill
force-pushed
the
deploy_image_to_openshift_3
branch
from
0206ed0
to
36555d4
Compare
| - Service | ||
| - Route 'Optional' | ||
|
|
||
| [Note] |
There was a problem hiding this comment.
in asciidoc you just write 👍
NOTE: The following steps require:
. Connection to a Docker demon already exist.
....
then it will be rendered nicely.
jcantrill
force-pushed
the
deploy_image_to_openshift_3
branch
from
36555d4
to
0b92d24
Compare
|
updated per @maxandersen comments. Not sure I fully addressed his requests |
jcantrill
force-pushed
the
deploy_image_to_openshift_3
branch
from
0b92d24
to
8620dd6
Compare
|
Merged as cee3c29 after some minor wording/formatting modifications |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fbricon @mishaone First pass at the docs. Need to be validated that links and formatting are correct, but he bulk of the content is there. Probably will change if we add the required enhancements before release