JBIDE-16657 - Handle case when cr == final in /downloads #73
Conversation
| - elsif page.build_info.build_type_label == :nightly | ||
| .alert.alert-warning | ||
| %strong Warning! | ||
| The | ||
| %strong nightly build | ||
| contains the latest and greatest new features, but nothing is stable or guaranteed - yet. | ||
|
|
||
| - elsif is_candidate_release_version(page.build_info.version) && has_final_version(site, page.build_info.product_id, page.build_info.version) |
There was a problem hiding this comment.
why does it matter if it is a CR version ? if there is a final version and the entry has the updatesite url is when the entry is to be shown.
There was a problem hiding this comment.
you mean when there's a .Final version and the current version has an update site url or zips of the update site ?
There was a problem hiding this comment.
no i mean if development site is beta and the next is a final - shouldn't happen but just thinks it is not about wether the site name is cr or not. its if there is a final/stable release for the development version.
|
Looks good - one caveat I noticed is that 4.1.0 final aren't warned about there being a 4.1.1 final :) |
|
IIRC, we said we would compare in a X.Y.Z range, i.e., warn that 4.1.1.Final exists when browsing 4.1.1.Alpha1 (for example) |
Added a banner on the page with a link to the latest version download page when there's a more recent version matching the current one (including 4.1.1.Final -> 4.1.2.Final)
|
looks great! applied. |
Added a banner on the page with a link to the .Final download page
when there's a .Final version matching the current .CRx one.