Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBWS-4251] changes for wfly-15598-usernametokenprofile #208

Merged

Conversation

rsearls
Copy link
Contributor

@rsearls rsearls commented May 31, 2022

This PR replaces #179. Added changes were needed to address the removal of picketbox from wfly. And on code change to resolve the test failure.

@jimma
Copy link
Member

jimma commented Jun 1, 2022

@rsearls As Alessio said in this comment: #204 (review), we usually put this security implementation in WFLY webservice integration layer in https://github.com/wildfly/wildfly/blob/main/webservices/server-integration/src/main/java/org/jboss/as/webservices/security/ElytronSecurityDomainContextImpl.java . Then we don't need to introduce elytron dependency in jbossws-cxf and we can still delegate this security check to WFLY integration.

…nge implemented. Added required groovy and pom file changes. wfly-15598-usernametokenprofile
@rsearls
Copy link
Contributor Author

rsearls commented Jun 9, 2022

This PR has a dependency on jbossws-spi (PR jbossws/jbossws-spi#14) required an API
change in order to not reference elytron code. And wildfly
https://issues.redhat.com/browse/WFLY-16473 Replacement, WebServices
UsernameToken profile integration with Elytron
PR wildfly/wildfly#15630

The jbossws-spi must be merged 1st so that wfly can resolve its reference.
Next wfly must be merged before tests will pass in jbossws-cxf

jbossws-cxf implements the jbossws-spi API change
but it also contains some required groovy script updates as well as property files

@rsearls rsearls merged commit a67f737 into jbossws:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants