Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testcase for nested extra keys #26

Merged
merged 2 commits into from Mar 2, 2023

Conversation

Baachi
Copy link
Contributor

@Baachi Baachi commented Mar 1, 2023

The RouterVoter requires a litte bit more complex structure in the extra keys, in order to calculate if an item is active or not.

Example:

account_tabs:
    tree:
        admin:
            label: Admin
            route: admin
            extras:
                routes:
                      - pattern: "/^admin/"
        profile:
            label: Profile
            route: profile
            extras:
                routes: 
                    - 'profile_update'
                    - 'profile_index'
                    - 'profile_change_password'

The RouteVoter want multiple values in order to mark an item as active.
@jbouzekri jbouzekri merged commit e34a3d3 into jbouzekri:master Mar 2, 2023
@jbouzekri
Copy link
Owner

@Baachi : Merged and tagged (7.1). Thank you !

@Baachi
Copy link
Contributor Author

Baachi commented Mar 2, 2023

@jbouzekri Thanks for you work and this bundle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants