Skip to content

Commit

Permalink
Fix #601
Browse files Browse the repository at this point in the history
  • Loading branch information
root committed Jan 2, 2017
1 parent 220e082 commit 08878c4
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Gemfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ gem 'org-ruby'
gem 'creole'
# gem 'wikicloth'
gem 'asciidoctor'
gem 'rdoc'

This comment has been minimized.

Sign in to view

Copy link
@mnencia

mnencia Mar 24, 2017

This change breaks an installation from scratch using ruby 2.3.3 and redmine 3.3

This comment has been minimized.

Sign in to view

Copy link
@n-rodriguez

n-rodriguez Mar 24, 2017

Contributor

Do you have error log?

This comment has been minimized.

Sign in to view

Copy link
@mnencia

mnencia Mar 24, 2017 •
edited
Loading

This is the error:

$ bundle install --gemfile Gemfile --without development,test,mysql,sqlite
Your Gemfile lists the gem redcarpet (~> 3.3.2) more than once.
You should probably keep only one of them.
While it's not a problem now, it could cause errors if you change the version of one of them later.

[!] There was an error parsing `Gemfile`:
[!] There was an error parsing `Gemfile`: You cannot specify the same gem twice with different version requirements.
You specified: rdoc (~> 4.3) and rdoc (>= 0). Bundler cannot continue.

 #  from /srv/redmine/redmine-3.3/plugins/redmine_git_hosting/Gemfile:31
 #  -------------------------------------------
 #  gem 'asciidoctor'
 >  gem 'rdoc'
 #
 #  -------------------------------------------
. Bundler cannot continue.

 #  from /srv/redmine/redmine-3.3/Gemfile:118
 #  -------------------------------------------
 #  Dir.glob File.expand_path("../plugins/*/{Gemfile,PluginGemfile}", __FILE__) do |file|
 >    eval_gemfile file
 #  end
 #  -------------------------------------------

If I remove the line it works like a charm:

$ bundle install --gemfile Gemfile --without development,test,mysql,sqlite
Your Gemfile lists the gem redcarpet (~> 3.3.2) more than once.
You should probably keep only one of them.
While it's not a problem now, it could cause errors if you change the version of one of them later.
Fetching https://github.com/jbox-web/gitolite-rugged.git
Fetching https://github.com/jbox-web/grack.git
The dependency tzinfo-data (>= 0) will be unused by any of the platforms Bundler is installing for. Bundler is installing for ruby but the dependency is only for x86-mingw32, x64-mingw32, x86-mswin32, java. To add those platforms to the bundle, run `bundle lock --add-platform x86-mingw32 x64-mingw32 x86-mswin32 java`.
The dependency activerecord-jdbc-adapter (~> 1.3.2) will be unused by any of the platforms Bundler is installing for. Bundler is installing for ruby but the dependency is only for java. To add those platforms to the bundle, run `bundle lock --add-platform java`.
The dependency activerecord-jdbcpostgresql-adapter (>= 0) will be unused by any of the platforms Bundler is installing for. Bundler is installing for ruby but the dependency is only for java. To add those platforms to the bundle, run `bundle lock --add-platform java`.
Fetching gem metadata from https://rubygems.org/.........
Fetching version metadata from https://rubygems.org/..
Fetching dependency metadata from https://rubygems.org/.
Resolving dependencies....
Installing rake 12.0.0
Installing RedCloth 4.3.2 with native extensions
Installing i18n 0.7.0
Installing json 1.8.6 with native extensions
Installing minitest 5.10.1
Installing thread_safe 0.3.6
Installing builder 3.2.3
Installing erubis 2.7.0
Installing mini_portile2 2.1.0
Installing rack 1.6.5
Installing mime-types-data 3.2016.0521
Installing arel 6.0.4
Installing public_suffix 2.0.5
Installing asciidoctor 1.5.5
Using bundler 1.14.6
Installing charlock_holmes 0.7.3 with native extensions
Installing ffi 1.9.18 with native extensions
Installing coderay 1.1.1
Installing concurrent-ruby 1.0.5
Installing connection_pool 2.2.1
Installing creole 0.5.0
Installing dalli 2.7.6
Installing docile 1.1.5
Installing escape_utils 1.1.1 with native extensions
Installing rugged 0.25.1.1 with native extensions
Installing rinku 2.0.2 with native extensions
Installing gratr19 0.4.4.1
Installing tilt 2.0.7
Installing sexp_processor 4.8.0
Installing thor 0.19.4
Installing hiredis 0.6.1 with native extensions
Installing htmlentities 4.3.1
Installing metaclass 0.0.4
Installing mimemagic 0.3.2
Installing multi_json 1.12.1
Installing net-ldap 0.12.1
Installing rubypants 0.6.0
Installing pg 0.18.4 with native extensions
Installing ruby-openid 2.3.0
Installing rbpdf-font 1.19.0
Installing rdoc 4.3.0
Installing redcarpet 3.3.4 with native extensions
Installing redis 3.3.3
Installing request_store 1.0.5
Installing rmagick 2.16.0 with native extensions
Installing rubyzip 1.2.1
Installing websocket 1.2.4
Installing simplecov-html 0.9.0
Installing will_paginate 3.1.5
Installing yard 0.9.8
Installing tzinfo 1.2.2
Installing nokogiri 1.6.8.1 with native extensions
Installing rack-test 0.6.3
Using gitlab-grack 2.0.0.pre from https://github.com/jbox-web/grack.git (at fix_rails4@1bc51d8)
Installing rack-parser 0.7.0
Installing rack-protection 1.5.3
Installing mime-types 3.1
Installing addressable 2.5.0
Installing childprocess 0.6.2
Installing sprockets 3.7.1
Using gitolite-rugged 1.2.0 from https://github.com/jbox-web/gitolite-rugged.git (at 1.2.0@551741d)
Installing haml 4.0.7
Installing ruby_parser 3.8.4
Installing mocha 1.2.1
Installing org-ruby 0.9.12
Installing rack-openid 1.4.2
Installing rbpdf 1.19.0
Installing simplecov 0.9.2
Installing activesupport 4.2.7.1
Installing loofah 2.0.3
Installing xpath 2.0.0
Installing webrat 0.7.3
Installing sidekiq 4.2.10
Installing sinatra 1.4.8
Installing mail 2.6.4
Installing github-linguist 5.0.8
Installing css_parser 1.4.10
Installing selenium-webdriver 2.53.4
Installing html2haml 2.1.0
Installing rails-deprecated_sanitizer 1.0.3
Installing globalid 0.3.7
Installing activemodel 4.2.7.1
Installing rails-html-sanitizer 1.0.3
Installing capybara 2.13.0
Installing github-markup 1.4.8
Installing roadie 3.2.1
Installing rails-dom-testing 1.0.8
Installing activejob 4.2.7.1
Installing activerecord 4.2.7.1
Installing protected_attributes 1.1.3
Installing actionview 4.2.7.1
Installing actionpack 4.2.7.1
Installing actionmailer 4.2.7.1
Installing actionpack-action_caching 1.2.0
Installing actionpack-xml_parser 1.0.2
Installing railties 4.2.7.1
Installing sprockets-rails 3.2.0
Installing haml-rails 0.9.0
Installing jquery-rails 3.1.4
Installing roadie-rails 1.1.1
Installing rails 4.2.7.1
Bundle complete! 49 Gemfile dependencies, 101 gems now installed.
Gems in the group development,test,mysql,sqlite were not installed.
Use `bundle show [gemname]` to see where a bundled gem is installed.
Post-install message from haml:

HEADS UP! Haml 4.0 has many improvements, but also has changes that may break
your application:

* Support for Ruby 1.8.6 dropped
* Support for Rails 2 dropped
* Sass filter now always outputs <style> tags
* Data attributes are now hyphenated, not underscored
* html2haml utility moved to the html2haml gem
* Textile and Maruku filters moved to the haml-contrib gem

For more info see:

http://rubydoc.info/github/haml/haml/file/CHANGELOG.md

Post-install message from yard:
--------------------------------------------------------------------------------
As of YARD v0.9.2:

RubyGems "--document=yri,yard" hooks are now supported. You can auto-configure
YARD to automatically build the yri index for installed gems by typing:

    $ yard config --gem-install-yri

See `yard config --help` for more information on RubyGems install hooks.

You can also add the following to your .gemspec to have YARD document your gem
on install:

    spec.metadata["yard.run"] = "yri" # use "yard" to build full HTML docs.

--------------------------------------------------------------------------------

This comment has been minimized.

Sign in to view

Copy link
@mnencia

mnencia Mar 25, 2017 •
edited
Loading

I just realized that my --without parameter was wrong, so it was installing with all the groups anyway. However, even with the right groups exclusion, it continues to fail with the same error.

This comment has been minimized.

Sign in to view

Copy link
@mnencia

mnencia Mar 25, 2017

Adding the version specifier fixes the issue

diff --git a/Gemfile b/Gemfile
index a85770d..5187bfd 100644
--- a/Gemfile
+++ b/Gemfile
@@ -28,7 +28,7 @@ gem 'org-ruby'
 gem 'creole'
 # gem 'wikicloth'
 gem 'asciidoctor'
-gem 'rdoc'
+gem 'rdoc', "~> 4.3"

 # Rack parser for Hrack
 gem 'rack-parser', require: 'rack/parser'

This comment has been minimized.

Sign in to view

Copy link
@mnencia

mnencia Mar 27, 2017

I've created the #663 pull request containing this patch.

# Rack parser for Hrack
gem 'rack-parser', require: 'rack/parser'

0 comments on commit 08878c4

Please sign in to comment.