Controller reconciliation rework - part 2 (ServiceBinding) (openshift…

…#1819)

* Controller reconciliation rework - part 2 (ServiceBinding)

* Exit the reconciliation loop iteration after each update to ServiceBinding

* Validate KubeClient and BrokerClient actions after each invocation of reconcileServiceBinding()

* Reduce code duplication in controller_binding_test.go

pkg/controller/controller_binding.go

@@ -232,6 +232,8 @@ func (c *controller) reconcileServiceBindingAdd(binding *v1beta1.ServiceBinding)
 			// over with a fresh view of the binding.
 			return err
 		}
+		// recordStartOfServiceBindingOperation has updated the binding, so we need to continue in the next iteration
+		return nil
 	}
 
 	response, err := brokerClient.Bind(request)
@@ -342,6 +344,8 @@ func (c *controller) reconcileServiceBindingDelete(binding *v1beta1.ServiceBindi
 				// over with a fresh view of the binding.
 				return err
 			}
+			// recordStartOfServiceBindingOperation has updated the binding, so we need to continue in the next iteration
+			return nil
 		}
 	}